Skip to content

Integration test for swatches types in attribute configuration added#17970

Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
rogyar:2.2-swatch-types-it
Sep 22, 2018
Merged

Integration test for swatches types in attribute configuration added#17970
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
rogyar:2.2-swatch-types-it

Conversation

@rogyar
Copy link
Copy Markdown
Contributor

@rogyar rogyar commented Sep 7, 2018

Description

This PR adds an integration test for Magento\Swatches\Observer\AddSwatchAttributeTypeObserver which checks that the swatches types are added to the attribute configuration form.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Sep 7, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Sep 7, 2018

Hi @rogyar. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.7 milestone Sep 7, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Sep 7, 2018

Hi @sidolov, thank you for the review.
ENGCOM-2936 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit dfaeb8d into magento:2.2-develop Sep 22, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Sep 22, 2018

Hi @rogyar. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@jignesh-baldha jignesh-baldha mentioned this pull request Oct 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sidolov sidolov sidolov approved these changes

Assignees

@sidolov sidolov

Labels

Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2

Projects

None yet

Milestone

Release: 2.2.7

Development

Successfully merging this pull request may close these issues.

3 participants

@rogyar @magento-engcom-team @sidolov